Skip to content

hyx: enable on darwin#93634

Merged
Mic92 merged 2 commits intoNixOS:masterfrom
sikmir:hyx
Aug 5, 2020
Merged

hyx: enable on darwin#93634
Mic92 merged 2 commits intoNixOS:masterfrom
sikmir:hyx

Conversation

@sikmir
Copy link
Copy Markdown
Member

@sikmir sikmir commented Jul 22, 2020 •
edited
Loading

Motivation for this change
  1. update to 2020.06.09
  2. enable on darwin (using memstream - POSIX memory streams for BSD, since macOS doesn't have open_memstream)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Jul 22, 2020
@sikmir sikmir requested review from Mic92 and fpletz July 22, 2020 09:46
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 22, 2020
@sikmir sikmir mentioned this pull request Jul 22, 2020
Closed
@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Aug 1, 2020

@GrahamcOfBorg build hyx

@Mic92 Mic92 merged commit 8e2b14a into NixOS:master Aug 5, 2020
@sikmir sikmir deleted the hyx branch August 5, 2020 10:28
@1000101 1000101 mentioned this pull request Oct 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sikmir @Mic92