Skip to content

icu: 64 -> 67#93482

Merged
marsam merged 2 commits intoNixOS:stagingfrom
marsam:update-icu
Jul 20, 2020
Merged

icu: 64 -> 67#93482
marsam merged 2 commits intoNixOS:stagingfrom
marsam:update-icu

Conversation

@marsam
Copy link
Copy Markdown
Contributor

@marsam marsam commented Jul 19, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. labels Jul 19, 2020
@marsam marsam merged commit d1bedf9 into NixOS:staging Jul 20, 2020
@marsam marsam deleted the update-icu branch July 20, 2020 23:37
@jtojnar jtojnar mentioned this pull request Jul 23, 2020
Merged
10 tasks
@B4dM4n B4dM4n mentioned this pull request Aug 5, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bhipple bhipple bhipple approved these changes

+1 more reviewer

@dasj19 dasj19 dasj19 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 1001-2500 This PR causes many rebuilds on Darwin and should most likely target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marsam @bhipple @dasj19