Skip to content

nixosTests.taskserver: Port to python#93413

Merged
tfc merged 1 commit intoNixOS:masterfrom
liff:taskserver-python-test
Aug 3, 2020
Merged

nixosTests.taskserver: Port to python#93413
tfc merged 1 commit intoNixOS:masterfrom
liff:taskserver-python-test

Conversation

@liff
Copy link
Copy Markdown
Contributor

@liff liff commented Jul 18, 2020

Motivation for this change

Making progress on #72828. Very much just a mechanical translation.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jul 18, 2020
@rnhmjoj rnhmjoj requested a review from tfc July 26, 2020 22:10
tfc
tfc reviewed Jul 27, 2020
View reviewed changes
tfc
tfc reviewed Jul 27, 2020
View reviewed changes
@tfc
Copy link
Copy Markdown
Contributor

tfc commented Jul 27, 2020

Wow this is one of the longer nixos tests. Thank you for porting this!

@liff liff force-pushed the taskserver-python-test branch from 75b010c to 6b1c347 Compare July 27, 2020 09:12
@tfc
Copy link
Copy Markdown
Contributor

tfc commented Aug 3, 2020

@GrahamcOfBorg test taskserver

@tfc tfc merged commit 319d7ec into NixOS:master Aug 3, 2020
@tfc tfc mentioned this pull request Aug 3, 2020
Closed
aszlig
aszlig reviewed Aug 15, 2020
View reviewed changes
nixos/tests/taskserver.nix
pass


def setup_clients_for(org, user, extra_init=no_extra_init):
Copy link
Copy Markdown
Member

@aszlig aszlig Aug 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use None instead and call the function IFF extra_init is not None?

Copy link
Copy Markdown
Contributor Author

@liff liff Aug 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to keep the call site slightly simpler, I guess. This is longer than it needs to be, though, since the no_extra_init function could be replaced by just lambda: None.

@liff liff deleted the taskserver-python-test branch November 14, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfc tfc tfc left review comments

@aszlig aszlig aszlig left review comments

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liff @tfc @aszlig