Skip to content

nixos/gitolite: provision data directory only before service begins#93001

Merged
flokli merged 1 commit intoNixOS:masterfrom
aanderse:gitolite
Jul 14, 2020
Merged

nixos/gitolite: provision data directory only before service begins#93001
flokli merged 1 commit intoNixOS:masterfrom
aanderse:gitolite

Conversation

@aanderse
Copy link
Copy Markdown
Member

@aanderse aanderse commented Jul 12, 2020

Motivation for this change

This PR aims to resolve #92473 by utilizing StateDirectory to provision directories after gitolite has started/been initialized.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested review from flokli, tokudan and zimbatm July 12, 2020 13:21
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 12, 2020
@aanderse
Copy link
Copy Markdown
Member Author

aanderse commented Jul 12, 2020 •
edited
Loading

@GrahamcOfBorg test gitolite gitolite-fcgiwrap

tokudan
tokudan approved these changes Jul 13, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tokudan tokudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good solution to me :)
I tested this change on 20.03 and it works well. Thanks!

@flokli flokli merged commit e99389a into NixOS:master Jul 14, 2020
@aanderse aanderse deleted the gitolite branch July 14, 2020 18:41
@flokli
Copy link
Copy Markdown
Member

flokli commented Jul 14, 2020

This shouldn't break any existing installs, the fact that dataDir isn't provisioned any more only covers new installations (and it's documented in the description), so this is fine :-)

@aanderse aanderse mentioned this pull request Jun 5, 2021
Merged
11 tasks
@aanderse aanderse mentioned this pull request Dec 4, 2021
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flokli flokli flokli approved these changes

@zimbatm zimbatm Awaiting requested review from zimbatm

+1 more reviewer

@tokudan tokudan tokudan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

gitolite creates directories through systemd.tmpfiles.rules

3 participants

@aanderse @flokli @tokudan