Skip to content

calibre: use webengine i/o webkit#92118

Merged
peterhoeg merged 1 commit intomasterfrom
f/calibre
Jul 4, 2020
Merged

calibre: use webengine i/o webkit#92118
peterhoeg merged 1 commit intomasterfrom
f/calibre

Conversation

@peterhoeg
Copy link
Copy Markdown
Member

Motivation for this change

As of v4, calibre supports qtwebengine so use that instead of the
deprecated qtwebkit.

This way we don't have to compile qtwebkit locally which is a PITA.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

As of v4, calibre supports qtwebengine so use that instead of the
deprecated qtwebkit.
@ofborg ofborg bot requested review from AndersonTorres, domenkozar and pSub July 3, 2020 02:02
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Jul 3, 2020
@veprbl veprbl mentioned this pull request Jul 3, 2020
69 tasks
@veprbl
Copy link
Copy Markdown
Member

veprbl commented Jul 3, 2020

Thanks. I missed that one when reviewing 16fe603

@peterhoeg peterhoeg merged commit 770faa0 into master Jul 4, 2020
@peterhoeg peterhoeg deleted the f/calibre branch July 4, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants