Skip to content

nixos/tests/partition.nix: remove#87084

Merged
flokli merged 1 commit intoNixOS:masterfrom
flokli:nixos-tests-partition.nix
May 6, 2020
Merged

nixos/tests/partition.nix: remove#87084
flokli merged 1 commit intoNixOS:masterfrom
flokli:nixos-tests-partition.nix

Conversation

@flokli
Copy link
Copy Markdown
Member

@flokli flokli commented May 6, 2020

This is still written in perl, wasn't part of all-tests.nix, and fails
even to build its dependencies (blivet, nixpart).

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
nixos/tests/partition.nix: remove
8b8e916 
This is still written in perl, wasn't part of all-tests.nix, and fails
even to build its dependencies (blivet, nixpart).
@flokli flokli requested review from Mic92 and tfc May 6, 2020 11:41
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels May 6, 2020
@davidak
Copy link
Copy Markdown
Member

davidak commented May 6, 2020

is the test desirable? then it might be good to create an issue to reimplement it and link to the last commit where it exists

but since there is no recommended tool for format using NixOS, this is probably not useful and be safely be removed

@flokli
Copy link
Copy Markdown
Member Author

flokli commented May 6, 2020

IIRC, this was a replacement for the broken testsuite in the nixpart/blivet in nixpkgs a long time ago. However, as this package itself is broken too, I don't really see a reason to keep it. We can always revive it from the git history if we want.

@flokli flokli merged commit c698c7e into NixOS:master May 6, 2020
@flokli flokli deleted the nixos-tests-partition.nix branch May 6, 2020 19:34
@tfc tfc mentioned this pull request Jun 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Mic92 approved these changes

@tfc tfc Awaiting requested review from tfc

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flokli @davidak @Mic92