Skip to content

ocamlPackages.owl: unbreak by reversing previous edits#86425

Merged
vbgl merged 1 commit intoNixOS:masterfrom
bcdarwin:unbreak-owl
May 6, 2020
Merged

ocamlPackages.owl: unbreak by reversing previous edits#86425
vbgl merged 1 commit intoNixOS:masterfrom
bcdarwin:unbreak-owl

Conversation

@bcdarwin
Copy link
Copy Markdown
Member

@bcdarwin bcdarwin commented Apr 30, 2020

cc @vbgl @matthewbauer

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Apr 30, 2020
@bcdarwin
Copy link
Copy Markdown
Member Author

bcdarwin commented May 1, 2020

@GrahamcOfBorg build ocamlPackages.owl

1 similar comment
@vbgl
Copy link
Copy Markdown
Contributor

vbgl commented May 1, 2020 •
edited
Loading

@GrahamcOfBorg build ocamlPackages.owl

vbgl
vbgl approved these changes May 1, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know enough about BLAS to comment about openblasCompat, but at least, this builds and runs fine…

@vbgl vbgl merged commit d737f31 into NixOS:master May 6, 2020
@bcdarwin bcdarwin deleted the unbreak-owl branch May 6, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vbgl vbgl vbgl approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ocamlPackages.owl is broken

2 participants

@bcdarwin @vbgl