Skip to content

fverb: init at unstable-2020-06-09#85776

Merged
jtojnar merged 1 commit intoNixOS:masterfrom
magnetophon:fvrb
Jun 24, 2020
Merged

fverb: init at unstable-2020-06-09#85776
jtojnar merged 1 commit intoNixOS:masterfrom
magnetophon:fvrb

Conversation

@magnetophon
Copy link
Copy Markdown
Member

@magnetophon magnetophon commented Apr 22, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 22, 2020
drewrisinger
drewrisinger suggested changes Apr 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave notes about why unstable. Maybe change line in all-packages.nix

@GrahamcOfBorg build fverb

@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Apr 29, 2020

@drewrisinger Thanks, all done.

drewrisinger
drewrisinger suggested changes Apr 29, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked at the repo, and it looks fairly out-of-date/inactive. Makes me semi wary of packaging this.

Also, in terms of naming, there seems to be some precedent for naming LV2 plugins as name-lv2 or name.lv2. I really don't have much familiarity with this ecosystem, just an observation. See e.g. https://github.com/NixOS/nixpkgs/blob/84cf00f98031e93f389f1eb93c4a7374a33cc0a9/pkgs/applications/audio/ir.lv2/default.nix

It does build locally via nixpkgs-review pr 85776. Untested

https://github.com/NixOS/nixpkgs/pull/85776
1 package built:
fverb

@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Apr 29, 2020

The repo is pretty new, yes, but not inactive or out of date.
None of that matters though, since an audio effect just needs to do 2 things: sound good and be reliable.
The sound is subjective (I think it sounds gorgeous), but the language it is written in (faust) makes the reliability a given.

Therefore I would argue: this package is mature, and should be included.

As for the name: I named the package ir.lv2 because upstream is called that.
Similar for other lv2's.

@drewrisinger
Copy link
Copy Markdown
Contributor

drewrisinger commented Apr 29, 2020

The repo is pretty new, yes, but not inactive or out of date.

You are correct. My mistake, moving too quick & making assumptions.

Ack. Changing to approved.
@GrahamcOfBorg build fverb

@drewrisinger drewrisinger self-requested a review April 29, 2020 14:48
doronbehar
doronbehar reviewed May 23, 2020
View reviewed changes
@magnetophon magnetophon mentioned this pull request Jun 5, 2020
Closed
10 tasks
@magnetophon magnetophon changed the title fverb: init at unstable-2020-04-04 fverb: init at unstable-2020-09-06 Jun 9, 2020
@drewrisinger
Copy link
Copy Markdown
Contributor

drewrisinger commented Jun 11, 2020

Convention is to write dates as YYYY-MM-DD, b/c then versions are strictly monotonically increasing left to right. Please change the commit message/title.

drewrisinger
drewrisinger reviewed Jun 11, 2020
View reviewed changes
pkgs/applications/audio/fverb/default.nix Outdated
Comment on lines 4 to 6
Copy link
Copy Markdown
Contributor

@drewrisinger drewrisinger Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking, but...

Suggested change
}:
stdenv.mkDerivation rec {
}:
stdenv.mkDerivation rec {

@doronbehar
Copy link
Copy Markdown
Contributor

doronbehar commented Jun 11, 2020

Convention is to write dates as YYYY-MM-DD

Nice catch!

@magnetophon magnetophon changed the title fverb: init at unstable-2020-09-06 fverb: init at unstable-2020-06-09 Jun 11, 2020
@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Jun 11, 2020

@drewrisinger drew All done!
@doronbehar lol!

If you are interested, I have a bunch of other, mostly audio related, PR's open! ;)

drewrisinger
drewrisinger approved these changes Jun 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Builds via OfBorg (aarch64, amd64)

jtojnar
jtojnar reviewed Jun 12, 2020
View reviewed changes
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Jun 12, 2020
@nixos-discourse
Copy link
Copy Markdown

nixos-discourse commented Jun 24, 2020

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/172

@jtojnar jtojnar merged commit 0512c8f into NixOS:master Jun 24, 2020
@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Jun 24, 2020

Thanks.

@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Jun 24, 2020

Thank you!

@magnetophon magnetophon deleted the fvrb branch June 24, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar left review comments

@doronbehar doronbehar doronbehar left review comments

+1 more reviewer

@drewrisinger drewrisinger drewrisinger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@magnetophon @drewrisinger @doronbehar @nixos-discourse @jtojnar