Skip to content

jalv: revert to gtk2 cause gtk3 wasn't showing the GUIs#85497

Merged
danieldk merged 1 commit intoNixOS:masterfrom
magnetophon:jalv
Aug 8, 2020
Merged

jalv: revert to gtk2 cause gtk3 wasn't showing the GUIs#85497
danieldk merged 1 commit intoNixOS:masterfrom
magnetophon:jalv

Conversation

@magnetophon
Copy link
Copy Markdown
Member

@magnetophon magnetophon commented Apr 18, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cillianderoiste April 18, 2020 14:56
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Apr 18, 2020
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Apr 19, 2020 •
edited
Loading

This has had a gtk3 ui since 1.2.0 according to the NEWS file https://gitlab.com/drobilla/jalv/-/blob/master/NEWS#L114. Can you share a screenshot or more info? We certainly don't want to revert to gtk2 as a solution.

@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Apr 19, 2020

Sure, the program has the functionality, it just doesn't work on NixOS.
When you open a plugin in the gtk3 version, you get the generated generic gui instead of the gui that comes with the plugin.
Is that clear enough?

@magnetophon magnetophon mentioned this pull request Aug 8, 2020
Merged
10 tasks
@danieldk danieldk merged commit 1a0abf7 into NixOS:master Aug 8, 2020
@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Aug 8, 2020

@danieldk Dank je wel! :)

@magnetophon magnetophon deleted the jalv branch August 8, 2020 16:08
@vcunat
Copy link
Copy Markdown
Member

vcunat commented Aug 8, 2020 •
edited
Loading

It was pushed by me (and signed). It's just GitHub getting this confused sometimes ;-)

I reported the bug to their support years ago, but apparently it doesn't feel important.

@danieldk
Copy link
Copy Markdown
Contributor

danieldk commented Aug 8, 2020

@vcunat thanks, felt like I had a blackout ;).

@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Aug 8, 2020

@vcunat Thank you then! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@magnetophon @worldofpeace @vcunat @danieldk