ecryptfs: enable building without python2 support#84515
Merged
Mic92 merged 1 commit intoNixOS:masterfrom May 26, 2020
Merged
Conversation
Contributor
|
@doronbehar We need to check if anything in nixpkgs that (possibly?) depends on ecryptfs doesn't need this feature. |
Member
It is hardly usable to any python package unless |
Contributor
Author
|
There's also a nixos test: https://github.com/NixOS/nixpkgs/blob/8d6555d423c1407130bc81b8789c632f231c6dd0/nixos/tests/ecryptfs.nix I think it was successful. Here's the HTML test results: ecryptfs-nixos-test-result.zip |
Contributor
Author
Indeed, I just learned that this: Doesn't work also without this PR. |
Member
|
Result of 1 package built:- ecryptfs |
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Since Python2 is EOL I think packages which don't absolutely need python2 shouldn't require them. Specifically for ecryptfs, I opened a bug regarding Python 3 support: https://bugs.launchpad.net/ecryptfs/+bug/1871236
Things done
enablePythonflag set tofalseby default that enables building ecryptfs without needing python at all.sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"allsome binary files (usually in./result/bin/)./result/bin/)nix path-info -Sbefore and after)