Merged
Conversation
Use rec instead of let in and use only 1 version attribute.
This was referenced Apr 3, 2020
Closed
bjornfor
approved these changes
Apr 3, 2020
Contributor
bjornfor
left a comment
There was a problem hiding this comment.
Nit: I don't see why we need uhd to be so configurable (i.e. all the device flags), but it's not important.
Contributor
|
Some of the options make the ensuing binary much smaller. Like removing
some of the X300 images. This can matter when trying to deploy to small
distributed systems.
…On Fri, Apr 3, 2020 at 8:27 AM Bjørn Forsman ***@***.***> wrote:
***@***.**** approved this pull request.
Nit: I don't see why we need uhd to be so configurable (i.e. all the
device flags), but it's not important.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#84183 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABLSDF3H7X5WUYJV7ZFMLTRKXI4BANCNFSM4L34UFRQ>
.
|
Contributor
Author
|
Thanks for your approval @bjornfor , |
Contributor
Author
|
The build results nixpkgs-review produced are available via cachix - https://app.cachix.org/cache/r-doronbehar . These are the store paths : |
Member
|
@GrahamcOfBorg eval |
bjornfor
approved these changes
Apr 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Update + Make uhd's build more configurable.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)