wolf-spectrum: init at 1.0.0 by matthiasbeyer · Pull Request #83579 · NixOS/nixpkgs

matthiasbeyer · 2020-03-28T09:23:43Z

Thanks for @mrVanDalo as this is only copy-paste from here: https://git.ingolf-wagner.de/palo/nixos-config/src/master/pkgs/wolf-spectrum/default.nix

Things done

magnetophon · 2020-03-28T10:41:59Z

pkgs/applications/audio/wolf-spectrum/default.nix

You might wanna check the homepage, description and maintainer.

Whops, sorry 'bout that.

magnetophon · 2020-03-28T16:55:32Z

Works for me!

pkgs/applications/audio/wolf-spectrum/default.nix

jonringer · 2020-03-31T18:20:03Z

pkgs/applications/audio/wolf-spectrum/default.nix

is there anyway to check that these are the correct install paths? Also, i don't see any headers being installed

Why would you need any headers?

What do you mean by correct install paths? I can tell you that this plugin worked in ardour5 with this setup... not sure what you want. 😄

I guess that's what i was looking for

stale · 2020-09-27T23:50:08Z

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

magnetophon · 2020-09-28T02:00:28Z

still important to me

mrVanDalo · 2020-11-25T11:11:09Z

@matthiasbeyer there is a merge conflict here.

thiagokokada · 2020-12-31T00:08:02Z

Result of nixpkgs-review pr 83579 1

1 package built:

wolf-spectrum

Don't know how to properly test this, but I ran the binary and it runs (with error because I probably doesn't have a proper JACK setup).

nixos-discourse · 2020-12-31T00:35:48Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/313

nh2 · 2020-12-31T00:59:38Z

pkgs/applications/audio/wolf-spectrum/default.nix

Randomly commented-out stuff, and this installPhase in general: Please add some comments that describe what's (not) copied and why.

I suspect from "BUILD_DSSI=false" above that it doesn't build and you might want it to build in the future -- a comment on "BUILD_DSSI=false" might be excellent for that (you may also want to make the makeFlags above multi-line to best be able to place your comment).

pkgs/applications/audio/wolf-spectrum/default.nix

SuperSandro2000 · 2021-01-20T15:23:41Z

pkgs/applications/audio/wolf-spectrum/default.nix

Suggested change

#cp -r bin/wolf-spectrum-dssi* $out/lib/dssi/

You forgot to remove the comment.

SuperSandro2000 · 2021-01-20T15:24:03Z

pkgs/applications/audio/wolf-spectrum/default.nix

Suggested change

mkdir -p $out/lib/lv2

#mkdir -p $out/lib/dssi

mkdir -p $out/lib/vst

mkdir -p $out/bin/

mkdir -p $out/lib/lv2 $out/lib/vst $out/bin/

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

SuperSandro2000 · 2021-02-01T19:01:02Z

pkgs/applications/audio/wolf-spectrum/default.nix

+    description = "Real-time 2D spectrogram plugin (LV2, VST and Jack)";
+    license = licenses.gpl3Plus;
+    maintainers = [ maintainers.matthiasbeyer ];
+    platforms = [ "i686-linux" "x86_64-linux" ];


Suggested change

platforms = [ "i686-linux" "x86_64-linux" ];

platforms = platforms.linux;

SuperSandro2000 · 2021-02-01T19:01:28Z

pkgs/applications/audio/wolf-spectrum/default.nix

You forgot to remove the comment.

ofborg bot added the 8.has: package (new) This PR adds a new package label Mar 28, 2020

ofborg bot requested a review from magnetophon March 28, 2020 09:32

ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 28, 2020

magnetophon suggested changes Mar 28, 2020

View reviewed changes

matthiasbeyer force-pushed the add-wolf-spectrum branch from 983ded6 to c073336 Compare March 28, 2020 12:01

ofborg bot added the 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. label Mar 28, 2020

magnetophon approved these changes Mar 28, 2020

View reviewed changes

jonringer reviewed Mar 31, 2020

View reviewed changes

magnetophon mentioned this pull request Jun 5, 2020

dawPlugins: init #89547

Closed

10 tasks

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 27, 2020

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Sep 28, 2020

ryantm added 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Oct 3, 2020

matthiasbeyer force-pushed the add-wolf-spectrum branch from 6a5eeec to 92239fa Compare November 25, 2020 18:12

ofborg bot added 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 25, 2020

thiagokokada approved these changes Dec 31, 2020

View reviewed changes

nh2 reviewed Dec 31, 2020

View reviewed changes

SuperSandro2000 requested changes Jan 18, 2021

View reviewed changes

matthiasbeyer force-pushed the add-wolf-spectrum branch from 0e2e9a0 to 9c1599c Compare January 20, 2021 15:13

SuperSandro2000 reviewed Jan 20, 2021

View reviewed changes

wolf-spectrum: init at 1.0.0

4f36b60

Signed-off-by: Matthias Beyer <mail@beyermatthias.de>

matthiasbeyer force-pushed the add-wolf-spectrum branch from 24f0bd9 to 4f36b60 Compare February 1, 2021 14:34

SuperSandro2000 requested changes Feb 1, 2021

View reviewed changes

fixup! wolf-spectrum: init at 1.0.0

eeab23f

matthiasbeyer closed this Apr 13, 2021

matthiasbeyer deleted the add-wolf-spectrum branch April 13, 2021 11:07

-    mkdir -p $out/lib/lv2
-    #mkdir -p $out/lib/dssi
-    mkdir -p $out/lib/vst
-    mkdir -p $out/bin/
+    mkdir -p $out/lib/lv2 $out/lib/vst $out/bin/

	platforms = [ "i686-linux" "x86_64-linux" ];
	platforms = platforms.linux;

Uh oh!

Conversation

matthiasbeyer commented Mar 28, 2020

Things done

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

magnetophon commented Mar 28, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stale bot commented Sep 27, 2020

Uh oh!

magnetophon commented Sep 28, 2020

Uh oh!

mrVanDalo commented Nov 25, 2020

Uh oh!

thiagokokada commented Dec 31, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nixos-discourse commented Dec 31, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

thiagokokada commented Dec 31, 2020 •

edited

Loading