Skip to content

Revert "luaPackages.luv: 1.30.0-0 -> 1.34.1-1"#83532

Merged
LnL7 merged 1 commit intoNixOS:masterfrom
LnL7:darwin-neovim
Mar 29, 2020
Merged

Revert "luaPackages.luv: 1.30.0-0 -> 1.34.1-1"#83532
LnL7 merged 1 commit intoNixOS:masterfrom
LnL7:darwin-neovim

Conversation

@LnL7
Copy link
Copy Markdown
Member

@LnL7 LnL7 commented Mar 27, 2020 •
edited
Loading

This reverts commit eaa4728.

With 81461cf luv also needs to be
downgraded until luarocks can be updated to 3.3.1 again.

Fixes #82727

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7
Revert "luaPackages.luv: 1.30.0-0 -> 1.34.1-1"
2206369 
This reverts commit eaa4728.

With 81461cf luv also needs to be
downgraded until luarocks can be updated to 3.3.1 again.

Fixes NixOS#82727
@ofborg ofborg bot added 6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Mar 27, 2020
@teto
Copy link
Copy Markdown
Member

teto commented Mar 28, 2020

On the luv issue, as we have no proper fix really (the current fix is just as complicated as the current one), I am fine with this. I have not understood yet if the issue on darwin was random or systematic (i.e., if it could be fixed by trying several times).

@LnL7
Copy link
Copy Markdown
Member Author

LnL7 commented Mar 28, 2020

For reference the darwin build worked fine with luarocks-3.3.1 + luv-1.34.1-1 (even without your changes). So once #80528 is resolved we just have to make sure to update both.

@LnL7 LnL7 merged commit f4da410 into NixOS:master Mar 29, 2020
@LnL7 LnL7 deleted the darwin-neovim branch March 29, 2020 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: lua Lua is a powerful, efficient, lightweight, embeddable scripting language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Neovim failing to build on Darwin and Darwin Hydra?

2 participants

@LnL7 @teto