Skip to content

geonkick: init at 2.3.3#82442

Merged
orivej-nixos merged 2 commits intoNixOS:masterfrom
magnetophon:geonkick
Aug 17, 2020
Merged

geonkick: init at 2.3.3#82442
orivej-nixos merged 2 commits intoNixOS:masterfrom
magnetophon:geonkick

Conversation

@magnetophon
Copy link
Copy Markdown
Member

@magnetophon magnetophon commented Mar 12, 2020 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Mar 12, 2020
mmahut
mmahut reviewed Mar 24, 2020
View reviewed changes
@magnetophon magnetophon force-pushed the geonkick branch 2 times, most recently from 4826a69 to fa2c6dc Compare March 26, 2020 06:17
@magnetophon magnetophon changed the title geonkick: init at 1.9.2 geonkick: init at 1.10.0 Apr 3, 2020
@magnetophon magnetophon changed the title geonkick: init at 1.10.0 geonkick: init at 2.0.0 Apr 18, 2020
@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Apr 19, 2020

@mmahut Could you have another look please?

@magnetophon magnetophon changed the title geonkick: init at 2.0.0 geonkick: init at 2.0.1 Apr 20, 2020
@magnetophon magnetophon changed the title geonkick: init at 2.0.1 geonkick: init at 2.0.2 Apr 22, 2020
@magnetophon magnetophon mentioned this pull request Jun 5, 2020
Closed
10 tasks
@magnetophon magnetophon changed the title geonkick: init at 2.0.2 geonkick: init at 2.1.1 Jun 8, 2020
@magnetophon magnetophon changed the title geonkick: init at 2.1.1 geonkick: init at 2.2.0 Jun 11, 2020
@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Jun 11, 2020

@mmahut @doronbehar @jtojnar Any comments on https://github.com/iurie-sw/geonkick/issues/87?

jtojnar
jtojnar reviewed Jun 11, 2020
View reviewed changes
@magnetophon magnetophon force-pushed the geonkick branch 2 times, most recently from 86bcac3 to 1bb48fc Compare June 11, 2020 16:22
@magnetophon magnetophon changed the title geonkick: init at 2.2.0 geonkick: init at 2.2.1 Jun 11, 2020
@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Jun 11, 2020 •
edited
Loading

I don't understand the error grahamcofborg-eval is giving.
Can someone explain?

@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Jun 11, 2020 •
edited
Loading

Looks unrelated to this PR. Something in master is printing a warning when it is not supposed to.

@magnetophon
Copy link
Copy Markdown
Member Author

magnetophon commented Jun 11, 2020

Thanks.

@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Jun 11, 2020

This commit needs to be reverted: 7be315a

@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Jun 12, 2020

@GrahamcOfBorg eval

@magnetophon magnetophon changed the title geonkick: init at 2.2.1 geonkick: init at 2.2.2 Jun 12, 2020
@magnetophon magnetophon changed the title geonkick: init at 2.2.2 geonkick: init at 2.2.3 Jun 12, 2020
jtojnar
jtojnar reviewed Jun 12, 2020
View reviewed changes
@magnetophon magnetophon force-pushed the geonkick branch 2 times, most recently from 8cd4ac3 to bb6c7f1 Compare June 12, 2020 13:55
@magnetophon magnetophon changed the title geonkick: init at 2.2.3 geonkick: init at 2.3.3 Aug 1, 2020
@orivej-nixos orivej-nixos merged commit f657042 into NixOS:master Aug 17, 2020
@magnetophon magnetophon deleted the geonkick branch August 17, 2020 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar left review comments

+1 more reviewer

@mmahut mmahut mmahut left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@magnetophon @jtojnar @mmahut @orivej-nixos