Skip to content

pythonPackages.signedjson: 1.0.0 -> 1.1.0#80449

Closed
jonringer wants to merge 1 commit intoNixOS:masterfrom
jonringer:fix-py2-signedjson
Closed

pythonPackages.signedjson: 1.0.0 -> 1.1.0#80449
jonringer wants to merge 1 commit intoNixOS:masterfrom
jonringer:fix-py2-signedjson

Conversation

@jonringer
Copy link
Copy Markdown
Contributor

@jonringer jonringer commented Feb 18, 2020 •
edited
Loading

Motivation for this change

noticed it was broken reviewing #80447

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 18, 2020
@jonringer
Copy link
Copy Markdown
Contributor Author

jonringer commented Feb 22, 2020

since #80447 is on pause, going to merge this as it's still an improvement, other branch and just rebase onto master again.

@jonringer
Copy link
Copy Markdown
Contributor Author

jonringer commented Feb 22, 2020

@GrahamcOfBorg build pythonPackages.signedjson
@GrahamcOfBorg build python3Packages.signedjson
@GrahamcOfBorg build python38Packages.signedjson

@jonringer
Copy link
Copy Markdown
Contributor Author

jonringer commented Feb 22, 2020

unfortunately this breaks matrix-synapse, which is the only consumer:

error: build of '/nix/store/sh6yaln159has3rk0x90kmkdn2gjip28-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80449
1 package failed to build:
matrix-synapse

3 package built:
python27Packages.signedjson python37Packages.signedjson python38Packages.signedjson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jonringer