Skip to content

nixosTests.plotinus: Port to Python#80067

Merged
worldofpeace merged 1 commit intoNixOS:masterfrom
tfc:port-plotinus-test
Feb 13, 2020
Merged

nixosTests.plotinus: Port to Python#80067
worldofpeace merged 1 commit intoNixOS:masterfrom
tfc:port-plotinus-test

Conversation

@tfc
Copy link
Copy Markdown
Contributor

@tfc tfc commented Feb 13, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfc tfc requested review from flokli and worldofpeace February 13, 2020 22:37
@tfc
Copy link
Copy Markdown
Contributor Author

tfc commented Feb 13, 2020

@GrahamcOfBorg test plotinus

@worldofpeace
Copy link
Copy Markdown
Contributor

We seriously have a lot of things for this program 16fa6f5#diff-03391cc228e4f3d0fe2f38d6af3abf9e.

@worldofpeace worldofpeace merged commit 694a8b2 into NixOS:master Feb 13, 2020
@tfc tfc deleted the port-plotinus-test branch February 14, 2020 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants