Skip to content

nixosTests.cockroachdb: Port to python#80047

Closed
tfc wants to merge 1 commit intoNixOS:masterfrom
tfc:port-cockroachdb-tests
Closed

nixosTests.cockroachdb: Port to python#80047
tfc wants to merge 1 commit intoNixOS:masterfrom
tfc:port-cockroachdb-tests

Conversation

@tfc
Copy link
Copy Markdown
Contributor

@tfc tfc commented Feb 13, 2020 •
edited
Loading

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfc tfc requested review from flokli and worldofpeace February 13, 2020 19:40
@ofborg ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Feb 13, 2020
@tfc tfc mentioned this pull request Feb 13, 2020
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Feb 13, 2020
@tfc
Copy link
Copy Markdown
Contributor Author

tfc commented Feb 13, 2020

I missed that @flokli implemented this in #73934 already. For some reason this works for me on one machine but not the other, i will investigate and maybe reopen.

@tfc tfc closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@flokli flokli Awaiting requested review from flokli

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@tfc