Skip to content

calibre: add missing dependency, fixes #78642#79608

Merged
veprbl merged 2 commits intoNixOS:masterfrom
chamatht:calibre
Feb 10, 2020
Merged

calibre: add missing dependency, fixes #78642#79608
veprbl merged 2 commits intoNixOS:masterfrom
chamatht:calibre

Conversation

@chamatht
Copy link
Copy Markdown
Contributor

@chamatht chamatht commented Feb 9, 2020

Fixes #78642
This commit adds pyqtwebengine.

Motivation for this change

Without pyqtwebengine, when you try to view an ebook, you get the following error

Traceback (most recent call last):
  File "/nix/store/1zqhszwa961qf3nciz5wv854sfff18ph-calibre-4.8.0/bin/.calibre-parallel-wrapped", line 20, in <module>
    sys.exit(main())
  File "/nix/store/1zqhszwa961qf3nciz5wv854sfff18ph-calibre-4.8.0/lib/calibre/calibre/utils/ipc/worker.py", line 209, in main
    result = func(*args, **kwargs)
  File "/nix/store/1zqhszwa961qf3nciz5wv854sfff18ph-calibre-4.8.0/lib/calibre/calibre/gui_launch.py", line 80, in ebook_viewer
    from calibre.gui2.viewer.main import main
  File "/nix/store/1zqhszwa961qf3nciz5wv854sfff18ph-calibre-4.8.0/lib/calibre/calibre/gui2/viewer/main.py", line 12, in <module>
    from PyQt5.QtWebEngineCore import QWebEngineUrlScheme
ImportError: No module named QtWebEngineCore

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)

  • Built on platform(s)

    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)

  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"

  • Tested execution of all binary files (usually in ./result/bin/)

  • Determined the impact on package closure size (by running nix path-info -S before and after)

  • Ensured that relevant documentation is up to date

  • Fits CONTRIBUTING.md.

This commit adds pyqtwebengine.
Without pyqtwebengine, viewing ebooks yeild the error
 "ImportError: No module named QtWebEngineCore".
@chamatht chamatht requested review from FRidh and peterhoeg February 9, 2020 10:05
@FRidh FRidh changed the title calibre: add missing dependency calibre: add missing dependency, fixes #78642 Feb 9, 2020
@FRidh
Copy link
Copy Markdown
Member

FRidh commented Feb 9, 2020

Fixes #78642

@chamatht chamatht removed the request for review from peterhoeg February 9, 2020 10:17
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Feb 9, 2020
@FRidh
Copy link
Copy Markdown
Member

FRidh commented Feb 9, 2020

As written in #78642, we should not need webkit anymore so that change needs to be made.

@chamatht
Copy link
Copy Markdown
Contributor Author

chamatht commented Feb 9, 2020

@FRidh made the change

@ofborg ofborg bot requested a review from pSub February 9, 2020 21:47
@veprbl veprbl mentioned this pull request Feb 10, 2020
69 tasks
Copy link
Copy Markdown
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works

@veprbl veprbl merged commit 16fe603 into NixOS:master Feb 10, 2020
@chamatht chamatht deleted the calibre branch February 10, 2020 10:58
@Janik-Haag Janik-Haag added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Calibre 4.x requires PyQtWebEngine for ebook reader

5 participants