calibre: add missing dependency, fixes #78642#79608
Merged
veprbl merged 2 commits intoNixOS:masterfrom Feb 10, 2020
Merged
Conversation
This commit adds pyqtwebengine. Without pyqtwebengine, viewing ebooks yeild the error "ImportError: No module named QtWebEngineCore".
Member
|
Fixes #78642 |
pSub
approved these changes
Feb 9, 2020
Member
|
As written in #78642, we should not need webkit anymore so that change needs to be made. |
Contributor
Author
|
@FRidh made the change |
69 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78642
This commit adds pyqtwebengine.
Motivation for this change
Without pyqtwebengine, when you try to view an ebook, you get the following error
Things done
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS linux)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.