Skip to content

nixosTests.printing: Port to Python#79327

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
tfc:port-printer-test
Feb 6, 2020
Merged

nixosTests.printing: Port to Python#79327
Mic92 merged 1 commit intoNixOS:masterfrom
tfc:port-printer-test

Conversation

@tfc
Copy link
Copy Markdown
Contributor

@tfc tfc commented Feb 6, 2020

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tfc
Copy link
Copy Markdown
Contributor Author

tfc commented Feb 6, 2020

@GrahamcOfBorg test printing

@tfc tfc requested review from flokli and worldofpeace February 6, 2020 10:31
@tfc tfc mentioned this pull request Feb 6, 2020
Closed
@Mic92 Mic92 merged commit f8a38f6 into NixOS:master Feb 6, 2020
@tfc tfc deleted the port-printer-test branch February 6, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@flokli flokli Awaiting requested review from flokli

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tfc @Mic92