Conversation
| }); | ||
|
|
||
| pulseaudio = super.pulseaudio.override({ | ||
| nativeBuildInputs = [ pkgs.pulseaudio pkgs.pkg-config ]; |
There was a problem hiding this comment.
@teto sorry it took me a while to respond, I've been busy but I never forgot :). As for my baby pulseaudio Lua module. According to my tests, it wasn't built right - I get the following error when trying to require it:
/nix/store/9mfzwhpbjqz2b6l8vvmcflg6fhdjshzb-luajit-2.1.0-beta3/bin/lua: error loading module 'pulseaudio' from file 'pulseaudio.so':
pulseaudio.so: cannot open shared object file: No such file or directory
stack traceback:
[C]: at 0x0045c7e0
[C]: in function 'require'
(command line):1: in main chunk
[C]: at 0x004061b0
I was wondering, why didn't you add to the overrides the make filags?, I mean these:
| nativeBuildInputs = [ pkgs.pulseaudio pkgs.pkg-config ]; | |
| nativeBuildInputs = [ pkgs.pulseaudio pkgs.pkg-config ]; | |
| makeFlags = [ | |
| "INST_LIBDIR=${placeholder "out"}/lib/lua/${lua.luaversion}" | |
| "INST_LUADIR=${placeholder "out"}/share/lua/${lua.luaversion}" | |
| "LUA_BINDIR=${placeholder "out"}/bin" | |
| ]; | |
| preBuild = '' | |
| mkdir -p ${placeholder "out"}/lib/lua/${lua.luaversion} | |
| ''; |
There was a problem hiding this comment.
seems like the luarocks bump broke some things for me as it stopped building with Warning: unmatched variable LUA_LIBDIR (and it used to at least build). The makeFlags should not be necessary as the lua infra should take care of it
There was a problem hiding this comment.
Check out my comment here: luarocks/luarocks#1155 (comment) . I've tested compilation of libluv on Nixpkgs with Luarocks 3.2.1 and I still had the same warnings and errors, it's just that they haven't broke the build. Waiting for upstream to respond.
|
@teto along with fixing the conflict, there's an interesting package I think we could put in Could you please try to add it and I'll test it? |
|
I've had a go at the package but it seems huge (42 MB), to compile tons of stuff with some difficulties. Sorry I do not have time for this at the moment but I might give it a try once it goes out of |
|
O.K @teto no big deal. In general, what is the best way to make a PR with a new Luarock based package? I once tried to add a line in |
|
@doronbehar that's how you describe. Just at the end don't commit everything but use |
|
I see. And what if we'd like to update |
Motivation for this change
forgot to add cassowary in the previous PR.
Also tried to move pulseaudio to the conventional package. @doronbehar could you check I haven't broken the package, there is a warning aobut a missing folder
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)