Merged
Conversation
Member
|
please fix the commit title and PR title according the contributing guidelines. Specifically, include the attribute name. |
553d20b to
1fc2ef2
Compare
Contributor
Author
|
Whoops, fixed, thanks for the heads-up. |
1fc2ef2 to
cfa2ceb
Compare
69 tasks
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/frescobaldi-under-hyprland-error-on-startup/30382/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Closes: #76847
3.0.0 does not work #76847 because it needs
wrapQtAppsHook.Also, version 3.1. is available, which replaces QtWebKit with QtWebEngine #53079.
Things done
I modeled the changes after #66796, which fixed the same problem for anki. That change uses pyqtwebengine, so I decided to move frescobaldi to 3.1.
I do not really understand these lines:
Without
makeWrapperArgs ..., startup fails with the same error as before,Without
dontWrapQtApps = true, frescobaldi starts. But anki has this line, so, what is it needed for?sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @sepi