Skip to content

frescobaldi: 3.0.0 -> 3.1#76889

Merged
veprbl merged 1 commit intoNixOS:masterfrom
puzzlewolf:frescobaldi
Jan 3, 2020
Merged

frescobaldi: 3.0.0 -> 3.1#76889
veprbl merged 1 commit intoNixOS:masterfrom
puzzlewolf:frescobaldi

Conversation

@puzzlewolf
Copy link
Copy Markdown
Contributor

@puzzlewolf puzzlewolf commented Jan 3, 2020

Motivation for this change

Closes: #76847

3.0.0 does not work #76847 because it needs wrapQtAppsHook.

Also, version 3.1. is available, which replaces QtWebKit with QtWebEngine #53079.

Things done

I modeled the changes after #66796, which fixed the same problem for anki. That change uses pyqtwebengine, so I decided to move frescobaldi to 3.1.

I do not really understand these lines:

  dontWrapQtApps = true;
  makeWrapperArgs = [
      "\${qtWrapperArgs[@]}"
  ];

Without makeWrapperArgs ..., startup fails with the same error as before,

qt.qpa.plugin: Could not find the Qt platform plugin "xcb" in ""

Without dontWrapQtApps = true, frescobaldi starts. But anki has this line, so, what is it needed for?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @sepi

@FRidh
Copy link
Copy Markdown
Member

FRidh commented Jan 3, 2020

please fix the commit title and PR title according the contributing guidelines. Specifically, include the attribute name.

@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 3, 2020
@puzzlewolf puzzlewolf changed the title 3.0.0 -> 3.1 frescobaldi: 3.0.0 -> 3.1 Jan 3, 2020
@puzzlewolf
Copy link
Copy Markdown
Contributor Author

puzzlewolf commented Jan 3, 2020

Whoops, fixed, thanks for the heads-up.

Copy link
Copy Markdown
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs on NixOS x86_64-linux

@veprbl veprbl merged commit c5e72fa into NixOS:master Jan 3, 2020
@puzzlewolf puzzlewolf deleted the frescobaldi branch January 3, 2020 22:47
@nixos-discourse
Copy link
Copy Markdown

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/frescobaldi-under-hyprland-error-on-startup/30382/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

frescobaldi fails to start

4 participants