Skip to content

nixosTests.haka: port to python#76707

Merged
infinisil merged 1 commit intoNixOS:masterfrom
Br1ght0ne:nixosTests.haka-python
Jan 1, 2020
Merged

nixosTests.haka: port to python#76707
infinisil merged 1 commit intoNixOS:masterfrom
Br1ght0ne:nixosTests.haka-python

Conversation

@Br1ght0ne
Copy link
Copy Markdown
Member

@Br1ght0ne Br1ght0ne commented Dec 30, 2019 •
edited
Loading

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tvestelind

This change is Reviewable

@Br1ght0ne
Copy link
Copy Markdown
Member Author

Br1ght0ne commented Dec 30, 2019

@GrahamcOfBorg test haka

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 30, 2019
infinisil
infinisil approved these changes Jan 1, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails, but it also failed in the same way before, so this is fine

@infinisil infinisil merged commit fd7a019 into NixOS:master Jan 1, 2020
@tfc tfc mentioned this pull request Jan 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@infinisil infinisil infinisil approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Br1ght0ne @infinisil