Skip to content

nixosTests.kexec: port to python and mark as broken#76560

Merged
flokli merged 1 commit intoNixOS:masterfrom
nh2:kexec-test-python
Jan 1, 2020
Merged

nixosTests.kexec: port to python and mark as broken#76560
flokli merged 1 commit intoNixOS:masterfrom
nh2:kexec-test-python

Conversation

@nh2
Copy link
Copy Markdown
Contributor

@nh2 nh2 commented Dec 27, 2019 •
edited
Loading

Motivation for this change

#72828

WIP Marking as broken because the test did not succeed for me before this commit (the Perl test hung forever), and this translation exhibits the same problem.

Maybe anyone knows more?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra

@tfc tfc mentioned this pull request Dec 27, 2019
Closed
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Dec 27, 2019

We don't have to fix every test in the port, you can mark it as broken.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 27, 2019
@nh2
nixosTests.kexec: port to python.
12e3503 
The test did not succeed for me before this commit
(the Perl test hung forever), and this translation exhibits
the same problem.
@nh2 nh2 force-pushed the kexec-test-python branch from a1e1306 to 12e3503 Compare December 27, 2019 00:22
@nh2
Copy link
Copy Markdown
Contributor Author

nh2 commented Dec 27, 2019

you can mark it as broken.

OK, added comment and removing WIP.

@nh2 nh2 changed the title [WIP] nixosTests.kexec: port to python. nixosTests.kexec: port to python and mark as broken Dec 27, 2019
@nh2
Copy link
Copy Markdown
Contributor Author

nh2 commented Dec 27, 2019 •
edited by worldofpeace
Loading

Trying anyway:

@GrahamcOfBorg test kexec

@flokli flokli merged commit 2393fa2 into NixOS:master Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nh2 @worldofpeace @flokli