Skip to content

Port NixOs tests to python#75695

Merged
veprbl merged 6 commits intoNixOS:masterfrom
kampka:port-tests
Dec 18, 2019
Merged

Port NixOs tests to python#75695
veprbl merged 6 commits intoNixOS:masterfrom
kampka:port-tests

Conversation

@kampka
Copy link
Copy Markdown
Contributor

@kampka kampka commented Dec 15, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 15, 2019
tfc
tfc requested changes Dec 15, 2019
View reviewed changes
@kampka kampka force-pushed the port-tests branch 2 times, most recently from b5ae4d8 to 95a83f1 Compare December 15, 2019 16:35
@kampka
Copy link
Copy Markdown
Contributor Author

kampka commented Dec 15, 2019

@tfc Addressed all comments and ported a few more tests

@tfc tfc mentioned this pull request Dec 15, 2019
Closed
@kampka kampka changed the title Port tests Port NixOs tests to python Dec 15, 2019
@veprbl
Copy link
Copy Markdown
Member

veprbl commented Dec 15, 2019

@GrahamcOfBorg test wireguard/namespaces
@GrahamcOfBorg test mailcatcher
@GrahamcOfBorg test limesurvey
@GrahamcOfBorg test lidarr
@GrahamcOfBorg test leaps
@GrahamcOfBorg test haproxy
@GrahamcOfBorg test initrd-network

@veprbl
Copy link
Copy Markdown
Member

veprbl commented Dec 15, 2019

@GrahamcOfBorg test wireguard.namespaces

@veprbl
Copy link
Copy Markdown
Member

veprbl commented Dec 15, 2019

@GrahamcOfBorg build wireguard-namespaces

@veprbl
Copy link
Copy Markdown
Member

veprbl commented Dec 15, 2019

@GrahamcOfBorg test initrdNetwork

@veprbl
Copy link
Copy Markdown
Member

veprbl commented Dec 15, 2019

@GrahamcOfBorg test wireguard-namespaces

@veprbl
Copy link
Copy Markdown
Member

veprbl commented Dec 15, 2019

@GrahamcOfBorg test limesurvey

veprbl
veprbl reviewed Dec 15, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This breaks limesurvey on aarch64-linux
https://hydra.nixos.org/job/nixos/trunk-combined/nixos.tests.limesurvey.aarch64-linux

@kampka
Copy link
Copy Markdown
Contributor Author

kampka commented Dec 16, 2019

@GrahamcOfBorg test limesurvey

@kampka
Copy link
Copy Markdown
Contributor Author

kampka commented Dec 16, 2019

@veprbl sadly, that test is a 'cannot reproduce' for me as I don't have access to an aarch64 machine right now.
I have dropped that commit from this PR.

@kampka
Copy link
Copy Markdown
Contributor Author

kampka commented Dec 16, 2019

@GrahamcOfBorg test wireguard-namespaces
@GrahamcOfBorg test mailcatcher
@GrahamcOfBorg test limesurvey
@GrahamcOfBorg test lidarr
@GrahamcOfBorg test leaps
@GrahamcOfBorg test haproxy
@GrahamcOfBorg test initrdNetwork

@veprbl veprbl merged commit fc47ec6 into NixOS:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfc tfc tfc approved these changes

@veprbl veprbl veprbl approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kampka @veprbl @tfc