Skip to content

nixosTests.haproxy: port test to python#75459

Closed
mmilata wants to merge 1 commit intoNixOS:masterfrom
mmilata:haproxy-python-test
Closed

nixosTests.haproxy: port test to python#75459
mmilata wants to merge 1 commit intoNixOS:masterfrom
mmilata:haproxy-python-test

Conversation

@mmilata
Copy link
Copy Markdown
Member

@mmilata mmilata commented Dec 10, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 10, 2019
@tfc tfc mentioned this pull request Dec 15, 2019
Closed
@kampka
Copy link
Copy Markdown
Contributor

kampka commented Dec 17, 2019

@GrahamcOfBorg test haproxy

@kampka
Copy link
Copy Markdown
Contributor

kampka commented Dec 18, 2019

Hi @mmilata
The PR looks good, but sadly I saw it too late and the test is already ported in master.
Sorry about that. If you don't see any issues with the master test, I think this PR can be closed.

@mmilata mmilata closed this Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmilata @kampka