Skip to content

nixos/networkd: only set gateway if it's explicitly specified in the module system#75193

Merged
fpletz merged 1 commit intoNixOS:masterfrom
Ma27:optional-networkd-gateway
Dec 15, 2019
Merged

nixos/networkd: only set gateway if it's explicitly specified in the module system#75193
fpletz merged 1 commit intoNixOS:masterfrom
Ma27:optional-networkd-gateway

Conversation

@Ma27
Copy link
Copy Markdown
Member

@Ma27 Ma27 commented Dec 8, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@Ma27 Ma27 requested review from andir and fpletz December 8, 2019 01:31
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 8, 2019
@Ma27 Ma27 force-pushed the optional-networkd-gateway branch from 2e5a621 to ff65638 Compare December 8, 2019 02:30
@fpletz fpletz merged commit 0f783bc into NixOS:master Dec 15, 2019
@Ma27 Ma27 deleted the optional-networkd-gateway branch December 16, 2019 09:08
@Ma27 Ma27 mentioned this pull request Dec 16, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fpletz fpletz Awaiting requested review from fpletz

@andir andir Awaiting requested review from andir

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Ma27 @fpletz