Skip to content

nixos/tests/gnome3: port to python#74943

Closed
x123 wants to merge 2 commits intoNixOS:masterfrom
x123:x123-gnome3-test-to-python
Closed

nixos/tests/gnome3: port to python#74943
x123 wants to merge 2 commits intoNixOS:masterfrom
x123:x123-gnome3-test-to-python

Conversation

@x123
Copy link
Copy Markdown
Contributor

@x123 x123 commented Dec 3, 2019 •
edited
Loading

Motivation for this change

Port gnome3 test to python for #72828

Things done

Ported gnome3 tests to python.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) nixos/tests/gnome3.nix
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@tfc tfc mentioned this pull request Dec 3, 2019
Closed
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Dec 3, 2019

Hi @x123, you may haven't seen in #72828, but I've actually taken on porting all the DE tests. And this one was probably done first, I just haven't PR'd it.

@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS labels Dec 3, 2019
@x123
Copy link
Copy Markdown
Contributor Author

x123 commented Dec 3, 2019

@worldofpeace Oh, alright....but how was I supposed to know if they weren't PR'ed or documented anywhere in the issue? I guess I'll stop trying to port any tests if it's not worth doing due to undocumented work duplication. Thanks for the heads up.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 3, 2019
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Dec 3, 2019

We followed up on IRC.

Screenshot from 2019-12-03 17 27 44

tfc
tfc reviewed Dec 5, 2019
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfc tfc tfc left review comments

Assignees

No one assigned

Labels

6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@x123 @worldofpeace @tfc