nixos/tests/munin: port to python#74935
Merged
flokli merged 1 commit intoNixOS:masterfrom Dec 7, 2019
x123:x123-munin-test-python
Merged
nixos/tests/munin: port to python#74935flokli merged 1 commit intoNixOS:masterfrom x123:x123-munin-test-python
flokli merged 1 commit intoNixOS:masterfrom
x123:x123-munin-test-python
Conversation
Member
|
cc @ToxicFrog #51980 |
Member
|
I think we shouldn't remove assertions to fix the test. Port the whole test and let it fail. |
Member
|
I think we shouldn't keep broken tests around in first place, but either fix or drop them ;-) |
Contributor
|
munin was broken by a perl change: #70930. A new perl has been released (5.30.1), so updating perl should unbreak munin. |
Contributor
Author
|
This should be fixed now with the original tests ported now that munin has been fixed. Thanks @bjornfor |
Member
|
Indeed! It seems the systemd timer unit is firing a bit slowly, I did override it in the test (and dropped some hydra workaround which shouldn't apply anymore). @x123 PTAL. |
Contributor
Author
|
@flokli LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Port munin test to python for #72828 to march towards completion for test ports.
Things done
I noticed this test didn't even work to begin with, and it seems to be that the
munin-nodemodule doesn't even load a single usable plugin (which makes themunin-cronportion of this test fail). After a bit of trying to get a plugin to work, I finally decided a minimal working test ported to python was better than a broken non-ported test.sandboxinnix.confon non-NixOS linux)nixos/tests/munin.nixNotify maintainers
cc @domenkozar