test-driver.py: sleep in between executing things periodically inside the vm#74868
Closed
flokli wants to merge 1 commit intoNixOS:masterfrom
Closed
test-driver.py: sleep in between executing things periodically inside the vm#74868flokli wants to merge 1 commit intoNixOS:masterfrom
flokli wants to merge 1 commit intoNixOS:masterfrom
Conversation
… the vm while it's fine to use an endless loop on a blocking socket, we can't do the same with executing commands inside the VM. instead, wait 1sec in between each interval.
Contributor
|
Hey @flokli this is not the right approach. The perl test driver uses the |
10 tasks
Contributor
|
see #74898 |
Member
Author
|
Closing in favor of #74898. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
while it's fine to use an endless loop on a blocking socket, we
can't do the same with executing commands inside the VM. instead, wait
1sec in between each interval.
Motivation for this change
I saw a lot of spam while waiting for a
wait_until_succeedsmethod to finish inside a nixos vm test.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @tfc