nixos/tests/tiddlywiki: port to python#74866
Merged
flokli merged 2 commits intoNixOS:masterfrom Dec 4, 2019
x123:x123-test-tiddlywiki
Merged
nixos/tests/tiddlywiki: port to python#74866flokli merged 2 commits intoNixOS:masterfrom x123:x123-test-tiddlywiki
flokli merged 2 commits intoNixOS:masterfrom
x123:x123-test-tiddlywiki
Conversation
tfc
reviewed
Dec 3, 2019
nixos/tests/tiddlywiki.nix
Outdated
| subtest "configured with different wikifolder", sub { | ||
| $configured->succeed("test -f /var/lib/tiddlywiki/tiddlywiki.info"); | ||
| }; | ||
| with subtest("configured with different wikifolder"): |
Contributor
There was a problem hiding this comment.
From reading the subtest title i don't really understand what the high level assumption is. the next subtest title's description however is very good because it tells what your expectation is.
Contributor
Author
There was a problem hiding this comment.
I legitimately have no idea what this particular test does that is not the same thing as the previous "By default creates empty wiki" test. I was literally just porting the behavior over to python from perl. I have simply removed this test since it appears to be a duplicate of a previous test (with a poor description to boot) @tfc
tfc
approved these changes
Dec 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Port
tiddlywikitest to python #72828Things done
Ported
tiddlywikitest to python.sandboxinnix.confon non-NixOS linux)nixos/tests/tiddlywiki.nixNotify maintainers
cc @