Merged
Conversation
tfc
reviewed
Dec 1, 2019
nixos/tests/ipv6.nix
Outdated
Contributor
There was a problem hiding this comment.
wouldn't it be more direct and stable to match out the group of the subtext that looks like an ip (four numbers separated by dots)?
tfc
reviewed
Dec 1, 2019
tfc
reviewed
Dec 1, 2019
tfc
reviewed
Dec 1, 2019
292c9c4 to
55c79bf
Compare
Member
Author
|
I've changed the test according to suggestions but noticed it randomly failing. It's possible that I broke it during the conversion, looking into this ... |
mmilata
commented
Dec 1, 2019
55c79bf to
d65ffa3
Compare
wait_for_address sometimes returned tentative address.
d65ffa3 to
6ebf84a
Compare
Member
Author
|
The problem was in the original test which sometimes ended up using tentative address. Should be fixed now, PTAL. |
Member
|
@ofborg test ipv6 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#72828
Things done
sandboxinnix.confon non-NixOS linux)