Skip to content

nixosTests.nat: port to python#74754

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
mmilata:nat-python-test
Dec 1, 2019
Merged

nixosTests.nat: port to python#74754
Mic92 merged 1 commit intoNixOS:masterfrom
mmilata:nat-python-test

Conversation

@mmilata
Copy link
Copy Markdown
Member

@mmilata mmilata commented Nov 30, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @rbvermaa

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 30, 2019
@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Dec 1, 2019

@GrahamcOfBorg eval

@Mic92
Copy link
Copy Markdown
Member

Mic92 commented Dec 1, 2019

@GrahamcOfBorg test nat.firewall nat.firewall-conntrack nat.standalone

@Mic92 Mic92 merged commit 282ecd2 into NixOS:master Dec 1, 2019
@tfc tfc mentioned this pull request Dec 1, 2019
Closed
@mmilata mmilata deleted the nat-python-test branch December 1, 2019 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmilata @Mic92