Skip to content

nixosTests.memcached: port to python#74312

Merged
globin merged 1 commit intoNixOS:masterfrom
Br1ght0ne:nixosTests.memcached-python
Nov 27, 2019
Merged

nixosTests.memcached: port to python#74312
globin merged 1 commit intoNixOS:masterfrom
Br1ght0ne:nixosTests.memcached-python

Conversation

@Br1ght0ne
Copy link
Copy Markdown
Member

@Br1ght0ne Br1ght0ne commented Nov 27, 2019 •
edited
Loading

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc

This change is Reviewable

@ofborg ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 27, 2019
tfc
tfc reviewed Nov 27, 2019
View reviewed changes
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 27, 2019
@tfc tfc mentioned this pull request Nov 27, 2019
Closed
@Br1ght0ne Br1ght0ne force-pushed the nixosTests.memcached-python branch from 8eef5a0 to af0f948 Compare November 27, 2019 10:03
@Br1ght0ne
Copy link
Copy Markdown
Member Author

Br1ght0ne commented Nov 27, 2019

@GrahamcOfBorg test memcached

@globin globin merged commit 470f29c into NixOS:master Nov 27, 2019
@Br1ght0ne Br1ght0ne deleted the nixosTests.memcached-python branch November 27, 2019 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfc tfc tfc approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Br1ght0ne @tfc @globin