Nixos test containers python port#74218
Merged
globin merged 3 commits intoNixOS:masterfrom Nov 27, 2019
Merged
Conversation
Contributor
Author
|
@GrahamcOfBorg test containers-bridge containers-ipv4 containers-ipv6 |
flokli
reviewed
Nov 26, 2019
Member
flokli
left a comment
There was a problem hiding this comment.
As all of these are very similar, what do you think about joining the network-related ones into a single testScript, and testing each variant in a subtest?
nixos/tests/containers-ipv4.nix
Outdated
Member
There was a problem hiding this comment.
I think we shouldn't overdo with grouping things into subtests. This should really be just a comment. ;-)
e528601 to
1479e03
Compare
Contributor
Author
|
@GrahamcOfBorg test containers-bridge containers-ipv containers-imperative |
1479e03 to
f58088c
Compare
Contributor
Author
|
@GrahamcOfBorg test containers-bridge containers-ip containers-imperative |
f58088c to
b1e9e7c
Compare
Contributor
Author
|
@GrahamcOfBorg test containers-bridge containers-ip containers-imperative |
b1e9e7c to
9de0a8a
Compare
Contributor
Author
|
@GrahamcOfBorg test containers-bridge containers-ip containers-imperative |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#72828
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @flokli @worldofpeace @Lassulus