Skip to content

nixosTests.rabbitmq: port to python#74123

Merged
Ma27 merged 1 commit intoNixOS:masterfrom
Br1ght0ne:nixosTests.rabbitmq-python
Nov 26, 2019
Merged

nixosTests.rabbitmq: port to python#74123
Ma27 merged 1 commit intoNixOS:masterfrom
Br1ght0ne:nixosTests.rabbitmq-python

Conversation

@Br1ght0ne
Copy link
Copy Markdown
Member

@Br1ght0ne Br1ght0ne commented Nov 25, 2019 •
edited
Loading

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @edolstra @offlinehacker

This change is Reviewable

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 25, 2019
@Br1ght0ne
Copy link
Copy Markdown
Member Author

Br1ght0ne commented Nov 25, 2019

@GrahamcOfBorg test rabbitmq

worldofpeace
worldofpeace reviewed Nov 25, 2019
View reviewed changes
nixos/tests/rabbitmq.nix
$one->waitUntilSucceeds("su -s ${pkgs.stdenv.shell} rabbitmq -c \"rabbitmqctl status\"");
machine.wait_for_unit("rabbitmq.service")
machine.wait_until_succeeds(
'su -s ${pkgs.stdenv.shell} rabbitmq -c "rabbitmqctl status"'
Copy link
Copy Markdown
Contributor

@worldofpeace worldofpeace Nov 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering why this uses stdenv,shell, this really shouldn't be an issue.
It should probably be

Suggested change
'su -s ${pkgs.stdenv.shell} rabbitmq -c "rabbitmqctl status"'
'su - rabbitmq -c "rabbitmqctl status"'

@tfc tfc mentioned this pull request Nov 25, 2019
Closed
@Ma27 Ma27 merged commit bf39cf8 into NixOS:master Nov 26, 2019
@Br1ght0ne
Copy link
Copy Markdown
Member Author

Br1ght0ne commented Nov 26, 2019

@Ma27 @worldofpeace Whoops, #74123 (comment) didn't get here in time :(

@Br1ght0ne Br1ght0ne mentioned this pull request Nov 26, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@worldofpeace worldofpeace worldofpeace left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Br1ght0ne @worldofpeace @Ma27