Skip to content

nixosTest.gocd-{agent,server}: port to python#74082

Merged
flokli merged 3 commits intoNixOS:masterfrom
flokli:nixos-test-port-gocd
Dec 3, 2019
Merged

nixosTest.gocd-{agent,server}: port to python#74082
flokli merged 3 commits intoNixOS:masterfrom
flokli:nixos-test-port-gocd

Conversation

@flokli
Copy link
Copy Markdown
Member

@flokli flokli commented Nov 24, 2019

Motivation for this change

#72828

These already failed on master, but according to #61309, the service seems to behave fine.

The tests might just need a small update.

Looking at the logs it seems like the agent tries to download agent-launcher.jar from https://localhost:8154, is the https endpoint and not enabled. This might be just a matter of reconfiguring it in there, not sure about the error message in the PR here.

Could you take a look at it? This might also help in unbreaking #61309.

cc @cryptix

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@flokli flokli mentioned this pull request Nov 24, 2019
Merged
10 tasks
@tfc tfc mentioned this pull request Nov 24, 2019
Closed
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 24, 2019
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Nov 25, 2019

@GrahamcOfBorg test gocd-agent gocd-server

@flokli
Copy link
Copy Markdown
Member Author

flokli commented Nov 25, 2019

As written in #61309 (comment), these currently fail on master, and obviously still do after the refactor.

Would be nice if the maintainers @grahamc and @swarren83 could take a look into this.

@flokli flokli force-pushed the nixos-test-port-gocd branch from 18d0e2f to f821817 Compare December 2, 2019 22:16
@flokli
Copy link
Copy Markdown
Member Author

flokli commented Dec 2, 2019

I took a look. Turns out, the slightly weird hostnames gocd_server and gocd_agent were changed to gocdserver and gocdagent inside java, which failed name resolution, causing the tests to fail.

@GrahamcOfBorg test gocd-agent gocd-server

@flokli
Copy link
Copy Markdown
Member Author

flokli commented Dec 3, 2019

The gocd-agent test still fails, but the gocd-server test succeeds.

Turns out, now it's mandatory to pass some credentials while registering agents to a server.

The gocd server adds an autoregister key to the config file it generates, which would need to be passed to the client, after the server has spun up.

As I don't maintain the gocd NixOS modules, and only intended to port these tests to python (which were entirely broken before) I don't feel like I should pick this up myself, and leave it up to the maintainers.

I marked the gocd-agent test as broken, because that's what it still is.

@flokli flokli merged commit c7d0ee7 into NixOS:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfc tfc tfc approved these changes

@grahamc grahamc Awaiting requested review from grahamc

@swarren83 swarren83 Awaiting requested review from swarren83

@infinisil infinisil Awaiting requested review from infinisil

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flokli @worldofpeace @tfc