Skip to content

nixosTests.sudo: port to python#74076

Merged
flokli merged 1 commit intoNixOS:masterfrom
Br1ght0ne:nixosTests.sudo-python
Nov 24, 2019
Merged

nixosTests.sudo: port to python#74076
flokli merged 1 commit intoNixOS:masterfrom
Br1ght0ne:nixosTests.sudo-python

Conversation

@Br1ght0ne
Copy link
Copy Markdown
Member

@Br1ght0ne Br1ght0ne commented Nov 24, 2019 •
edited
Loading

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @lschuermann

This change is Reviewable

@ofborg ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 24, 2019
@tfc tfc mentioned this pull request Nov 24, 2019
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 24, 2019
@flokli flokli merged commit 013b9a8 into NixOS:master Nov 24, 2019
@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 24, 2019

Thanks!

@lschuermann
Copy link
Copy Markdown
Member

lschuermann commented Nov 25, 2019

Looks great, thank you very much. 👍

@Br1ght0ne Br1ght0ne deleted the nixosTests.sudo-python branch November 25, 2019 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Br1ght0ne @flokli @lschuermann