Skip to content

nixosTests.glusterfs: port to python#74003

Merged
flokli merged 1 commit intoNixOS:masterfrom
nh2:nixos-tests-port-glusterfs
Nov 24, 2019
Merged

nixosTests.glusterfs: port to python#74003
flokli merged 1 commit intoNixOS:masterfrom
nh2:nixos-tests-port-glusterfs

Conversation

@nh2
Copy link
Copy Markdown
Contributor

@nh2 nh2 commented Nov 24, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@nh2 nh2 requested a review from flokli November 24, 2019 00:38
@tfc tfc mentioned this pull request Nov 24, 2019
Closed
@ofborg ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 24, 2019
@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 24, 2019

@GrahamcOfBorg test glusterfs

flokli
flokli reviewed Nov 24, 2019
View reviewed changes
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 24, 2019
@nh2
nixosTests.glusterfs: port to python
3a38343 
Also fix a hardcoded sleep.
@nh2 nh2 force-pushed the nixos-tests-port-glusterfs branch from 17b3712 to 3a38343 Compare November 24, 2019 01:01
@nh2
Copy link
Copy Markdown
Contributor Author

nh2 commented Nov 24, 2019

@GrahamcOfBorg test glusterfs

@flokli flokli merged commit 6e60f84 into NixOS:master Nov 24, 2019
@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 24, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@flokli flokli flokli approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nh2 @flokli