Skip to content

nixosTests.bees: port to python#74001

Merged
globin merged 1 commit intoNixOS:masterfrom
flokli:nixos-test-port-bees
Nov 24, 2019
Merged

nixosTests.bees: port to python#74001
globin merged 1 commit intoNixOS:masterfrom
flokli:nixos-test-port-bees

Conversation

@flokli
Copy link
Copy Markdown
Member

@flokli flokli commented Nov 24, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@tfc tfc mentioned this pull request Nov 24, 2019
Closed
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 24, 2019
worldofpeace
worldofpeace suggested changes Nov 24, 2019
View reviewed changes
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Nov 24, 2019 •
edited
Loading

We also need to add bees to all-tests.nix.
And possible reference the test in the packages passthru

@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Nov 24, 2019

@GrahamcOfBorg test bees

tfc
tfc reviewed Nov 24, 2019
View reviewed changes
@flokli flokli force-pushed the nixos-test-port-bees branch from 5d19dda to 2cae1dc Compare November 24, 2019 16:21
@flokli
Copy link
Copy Markdown
Member Author

flokli commented Nov 24, 2019

@worldofpeace I adressed all changes, except adding the test to passthru - bees is packaged in a slightly weird way, didn't really want to touch that.

@globin globin force-pushed the nixos-test-port-bees branch from 2cae1dc to ca12e08 Compare November 24, 2019 17:50
@globin globin merged commit ff64fee into NixOS:master Nov 24, 2019
@flokli flokli deleted the nixos-test-port-bees branch November 24, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfc tfc tfc left review comments

@charles-dyfis-net charles-dyfis-net Awaiting requested review from charles-dyfis-net

@fpletz fpletz Awaiting requested review from fpletz

+1 more reviewer

@worldofpeace worldofpeace worldofpeace requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@flokli @worldofpeace @tfc @globin