Skip to content

nixos/kerberos: port tests to python#73961

Merged
flokli merged 1 commit intoNixOS:masterfrom
kwohlfahrt:kerberos-tests-python
Nov 24, 2019
Merged

nixos/kerberos: port tests to python#73961
flokli merged 1 commit intoNixOS:masterfrom
kwohlfahrt:kerberos-tests-python

Conversation

@kwohlfahrt
Copy link
Copy Markdown
Contributor

@kwohlfahrt kwohlfahrt commented Nov 23, 2019

Motivation for this change

Port tests for #72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc

@ofborg ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 23, 2019
tfc
tfc reviewed Nov 23, 2019
View reviewed changes
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 23, 2019
@kwohlfahrt kwohlfahrt force-pushed the kerberos-tests-python branch from d30e75d to 72348f0 Compare November 23, 2019 18:16
tfc
tfc reviewed Nov 23, 2019
View reviewed changes
@kwohlfahrt kwohlfahrt force-pushed the kerberos-tests-python branch from 72348f0 to d28fd8f Compare November 23, 2019 19:45
@kwohlfahrt
Copy link
Copy Markdown
Contributor Author

kwohlfahrt commented Nov 23, 2019

FYI the last force-push is using format strings (f"{unit}.service" instead of "{}.service".format(unit)")

@flokli flokli merged commit 65e3bf8 into NixOS:master Nov 24, 2019
@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 24, 2019

Thanks!

@tfc tfc mentioned this pull request Nov 24, 2019
Closed
@kwohlfahrt kwohlfahrt deleted the kerberos-tests-python branch December 18, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfc tfc tfc approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kwohlfahrt @flokli @tfc