Skip to content

nixosTests.mpd: port to python#73935

Merged
fpletz merged 1 commit intoNixOS:masterfrom
flokli:nixos-test-port-mpd
Nov 22, 2019
Merged

nixosTests.mpd: port to python#73935
fpletz merged 1 commit intoNixOS:masterfrom
flokli:nixos-test-port-mpd

Conversation

@flokli
Copy link
Copy Markdown
Member

@flokli flokli commented Nov 22, 2019

Motivation for this change

#72828

This needs some close look, as porting wasn't quite straightforward. We might also want to preserve some of the or die logic, and not just assertions, not sure.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc

@flokli flokli requested a review from fpletz November 22, 2019 20:25
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 22, 2019
@fpletz fpletz merged commit a7fa519 into NixOS:master Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants