Skip to content

tests/systemd-networkd-wireguard: migrate to python test runner#73699

Merged
flokli merged 1 commit intoNixOS:masterfrom
picnoir:wg-test-python
Nov 22, 2019
Merged

tests/systemd-networkd-wireguard: migrate to python test runner#73699
flokli merged 1 commit intoNixOS:masterfrom
picnoir:wg-test-python

Conversation

@picnoir
Copy link
Copy Markdown
Member

@picnoir picnoir commented Nov 18, 2019 •
edited
Loading

Updating systemd-networkd-wireguard to use the python test runner.

This change was purely syntactic. This migration did not require any
semantic change.

Motivation for this change

Part of #72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @tfc

@picnoir
tests/systemd-networkd-wireguard: migrate to make-test-python
fe12d5d 
Updating `systemd-networkd-wireguard` to use the python test runner.

This change was purely syntactic. This migration did not require any
semantic change.
@ofborg ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 18, 2019
@picnoir
Copy link
Copy Markdown
Member Author

picnoir commented Nov 18, 2019

@GrahamcOfBorg test systemd-networkd-wireguard

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 18, 2019
@tfc tfc mentioned this pull request Nov 20, 2019
Closed
@flokli flokli merged commit 0b0da4c into NixOS:master Nov 22, 2019
@picnoir picnoir deleted the wg-test-python branch November 22, 2019 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfc tfc tfc approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@picnoir @tfc @flokli