Skip to content

nixosTests.pantheon: port to python#73140

Merged
flokli merged 4 commits intoNixOS:masterfrom
worldofpeace:port-pantheon-test
Nov 25, 2019
Merged

nixosTests.pantheon: port to python#73140
flokli merged 4 commits intoNixOS:masterfrom
worldofpeace:port-pantheon-test

Conversation

@worldofpeace
Copy link
Copy Markdown
Contributor

@worldofpeace worldofpeace commented Nov 9, 2019 •
edited
Loading

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Nov 9, 2019

cc @tfc @marijanp

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 9, 2019
jtojnar
jtojnar approved these changes Nov 9, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mmahut
Copy link
Copy Markdown
Member

mmahut commented Nov 10, 2019

@GrahamcOfBorg test pantheon

@mmahut
Copy link
Copy Markdown
Member

mmahut commented Nov 10, 2019

@GrahamcOfBorg test pantheon

(odd timeout on 64).

@tfc tfc mentioned this pull request Nov 11, 2019
Closed
@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 11, 2019

@worldofpeace I also ran into the same timeouts / 100% cpu usage as described in #73190 (comment).

@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Nov 11, 2019

@flokli Ah, I guess this is a bug... I've been trying to port the DE tests but its been practically impossible to discern whether there's something wrong in my test script with debug logging or trying the same in the driver.

@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Nov 25, 2019 •
edited
Loading

Ok, now using subtest FTW 🌠.

However can't test on ofborg because it'll just timeout rebuilding the kernel.
So holding off on merging until then. I want to be sure this one doesn't timeout like before as we confirmed that on ofborg.

@jonringer
Copy link
Copy Markdown
Contributor

jonringer commented Nov 25, 2019

don't forget to squash commits :)

@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 25, 2019

This did succeed on my box:

5 out of 5 tests succeeded
test script finished in 74.98s

@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 25, 2019

@GrahamcOfBorg test pantheon

@flokli flokli merged commit b16ddb9 into NixOS:master Nov 25, 2019
@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 25, 2019

Thanks!

@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 25, 2019

oh sorry, I forgot to do the squash :-/

@worldofpeace worldofpeace deleted the port-pantheon-test branch November 25, 2019 20:10
@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Nov 25, 2019

oh sorry, I forgot to do the squash :-/

No problem. I was planning on using the squash merge feature for this.
I'll think of it as an extra few commits for descriptiveness 😄

@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Nov 26, 2019

So this test has timed out on hydra on the OCR step matching the bob user's description

Commented it out in 406efdb.
Hopefully there's no other issues with OCR, it wasn't a problem in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar approved these changes

@flokli flokli Awaiting requested review from flokli

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: pantheon The Pantheon desktop environment 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@worldofpeace @mmahut @flokli @jonringer @jtojnar