Skip to content

nixosTests.xmonad: port to python#73137

Merged
worldofpeace merged 1 commit intoNixOS:masterfrom
worldofpeace:port-xmonad-test
Nov 11, 2019
Merged

nixosTests.xmonad: port to python#73137
worldofpeace merged 1 commit intoNixOS:masterfrom
worldofpeace:port-xmonad-test

Conversation

@worldofpeace
Copy link
Copy Markdown
Contributor

@worldofpeace worldofpeace commented Nov 9, 2019

Motivation for this change

#72828

I'm not sure if this test was broken before this.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Nov 9, 2019

cc @tfc @marijanp

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 9, 2019
@mmahut
Copy link
Copy Markdown
Member

mmahut commented Nov 10, 2019

@GrahamcOfBorg test xmonad

marijanp
marijanp approved these changes Nov 11, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@marijanp marijanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes are appropriate. We may contact the maintainer of the test to see if we can make this test succeed.

@tfc tfc mentioned this pull request Nov 11, 2019
Closed
@worldofpeace worldofpeace merged commit deb1252 into NixOS:master Nov 11, 2019
@worldofpeace worldofpeace deleted the port-xmonad-test branch November 11, 2019 20:23
@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Nov 11, 2019

The changes are appropriate. We may contact the maintainer of the test to see if we can make this test succeed.

I can open an issue for this, thanks.

@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Nov 11, 2019 •
edited
Loading

Actually, perhaps this is a false assumption https://hydra.nixos.org/build/106281743

Guess I will look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfc tfc tfc approved these changes

@flokli flokli Awaiting requested review from flokli

@jonringer jonringer Awaiting requested review from jonringer

+1 more reviewer

@marijanp marijanp marijanp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@worldofpeace @mmahut @tfc @marijanp