Skip to content

nixosTests.lightdm: port to python#73135

Merged
worldofpeace merged 1 commit intoNixOS:masterfrom
worldofpeace:port-lightdm-test
Nov 10, 2019
Merged

nixosTests.lightdm: port to python#73135
worldofpeace merged 1 commit intoNixOS:masterfrom
worldofpeace:port-lightdm-test

Conversation

@worldofpeace
Copy link
Copy Markdown
Contributor

@worldofpeace worldofpeace commented Nov 9, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@worldofpeace
Copy link
Copy Markdown
Contributor Author

worldofpeace commented Nov 9, 2019

cc @tfc @marijanp

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 9, 2019
@mmahut
Copy link
Copy Markdown
Member

mmahut commented Nov 10, 2019

@GrahamcOfBorg test lightdm

@worldofpeace worldofpeace merged commit 8cf9315 into NixOS:master Nov 10, 2019
@worldofpeace worldofpeace deleted the port-lightdm-test branch November 10, 2019 23:05
@tfc tfc mentioned this pull request Nov 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfc tfc tfc approved these changes

@flokli flokli Awaiting requested review from flokli

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@worldofpeace @mmahut @tfc