Port tests to python#73131
Port tests to python#73131flokli merged 14 commits intoNixOS:masterfrom 1000101:port-tests-to-python
Conversation
|
@GrahamcOfBorg test roundcube |
|
This looks like a pretty straight forward and mechanical conversion. I spotted no issues. |
nixos/tests/roundcube.nix
Outdated
|
Should I drop the tests that are failing on arm or is this good to go? |
|
@1000101 did these fail on arm previously, too? Can you rebase on latest master? |
Jackett and hibernate have been failing on arm before (source: hydra). Rebased! |
|
@GrahamcOfBorg test roundcube |
|
This is a bit hard to merge, can this be broken down to individual PRs? |
|
Ok, it was mostly the roundcube fix already fixed in e292be7. Dropped that commit and rebased on master. |
|
Built and succeeded running all updated tests locally (x86_64), merging. |
Thanks a million!!! |
Motivation for this change
#72828
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @