Skip to content

Port tests to python#73131

Merged
flokli merged 14 commits intoNixOS:masterfrom
1000101:port-tests-to-python
Nov 22, 2019
Merged

Port tests to python#73131
flokli merged 14 commits intoNixOS:masterfrom
1000101:port-tests-to-python

Conversation

@1000101
Copy link
Copy Markdown
Member

@1000101 1000101 commented Nov 9, 2019

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 2.status: merge conflict This PR has merge conflicts with the target branch and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 9, 2019
@mmahut
Copy link
Copy Markdown
Member

mmahut commented Nov 10, 2019

@GrahamcOfBorg test roundcube
@GrahamcOfBorg test fancontrol
@GrahamcOfBorg test deluge
@GrahamcOfBorg test clickhouse
@GrahamcOfBorg test firewall
@GrahamcOfBorg test fish
@GrahamcOfBorg test fluentd
@GrahamcOfBorg test hibernate
@GrahamcOfBorg test hound
@GrahamcOfBorg test handbrake
@GrahamcOfBorg test icingaweb2
@GrahamcOfBorg test incron
@GrahamcOfBorg test minidlna
@GrahamcOfBorg test jackett
@GrahamcOfBorg test miniflux
@GrahamcOfBorg test haproxy

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 10, 2019
@blitz
Copy link
Copy Markdown
Contributor

blitz commented Nov 11, 2019

This looks like a pretty straight forward and mechanical conversion. I spotted no issues.
@tfc Ping.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh good catch... 👍

@1000101
Copy link
Copy Markdown
Member Author

1000101 commented Nov 18, 2019

Should I drop the tests that are failing on arm or is this good to go?

@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 21, 2019

@1000101 did these fail on arm previously, too?

Can you rebase on latest master?

@veprbl veprbl added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 21, 2019
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 22, 2019
@1000101
Copy link
Copy Markdown
Member Author

1000101 commented Nov 22, 2019

@1000101 did these fail on arm previously, too?

Can you rebase on latest master?

Jackett and hibernate have been failing on arm before (source: hydra).

Rebased!

@mmahut
Copy link
Copy Markdown
Member

mmahut commented Nov 22, 2019

@GrahamcOfBorg test roundcube
@GrahamcOfBorg test fancontrol
@GrahamcOfBorg test deluge
@GrahamcOfBorg test clickhouse
@GrahamcOfBorg test firewall
@GrahamcOfBorg test fish
@GrahamcOfBorg test fluentd
@GrahamcOfBorg test hibernate
@GrahamcOfBorg test hound
@GrahamcOfBorg test handbrake
@GrahamcOfBorg test icingaweb2
@GrahamcOfBorg test incron
@GrahamcOfBorg test minidlna
@GrahamcOfBorg test jackett
@GrahamcOfBorg test miniflux
@GrahamcOfBorg test haproxy

@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 22, 2019

This is a bit hard to merge, can this be broken down to individual PRs?

@flokli flokli added the 9.needs: reporter feedback This issue needs the person who filed it to respond label Nov 22, 2019
@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 22, 2019

Ok, it was mostly the roundcube fix already fixed in e292be7. Dropped that commit and rebased on master.

@flokli
Copy link
Copy Markdown
Member

flokli commented Nov 22, 2019

Built and succeeded running all updated tests locally (x86_64), merging.

@flokli flokli merged commit c81e4f1 into NixOS:master Nov 22, 2019
@1000101 1000101 deleted the port-tests-to-python branch November 22, 2019 20:56
@1000101
Copy link
Copy Markdown
Member Author

1000101 commented Nov 22, 2019

Ok, it was mostly the roundcube fix already fixed in e292be7. Dropped that commit and rebased on master.

Thanks a million!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 9.needs: reporter feedback This issue needs the person who filed it to respond 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants