Skip to content

nixos/samba: use tmpfiles, port test to python#73080

Merged
aanderse merged 2 commits intoNixOS:masterfrom
flokli:nixos-samba-python-tmpfiles
Nov 10, 2019
Merged

nixos/samba: use tmpfiles, port test to python#73080
aanderse merged 2 commits intoNixOS:masterfrom
flokli:nixos-samba-python-tmpfiles

Conversation

@flokli
Copy link
Copy Markdown
Member

@flokli flokli commented Nov 8, 2019

This updates the samba module to use tmpfiles, and ports the test to python.

Motivation for this change

#72828

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@tfc tfc mentioned this pull request Nov 8, 2019
Closed
@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 8, 2019
@worldofpeace
Copy link
Copy Markdown
Contributor

worldofpeace commented Nov 9, 2019

@GrahamcOfBorg test samba

aanderse
aanderse approved these changes Nov 10, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aanderse aanderse merged commit d2d009f into NixOS:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aanderse aanderse aanderse approved these changes

+1 more reviewer

@worldofpeace worldofpeace worldofpeace approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flokli @worldofpeace @aanderse