Merged
Conversation
Member
Author
|
Tested running borgbackup.nix |
Member
Author
Contributor
FRidh
reviewed
Nov 8, 2019
nixos/lib/test-driver/test-driver.py
Outdated
Member
There was a problem hiding this comment.
maybe bring the correct type forward, so m = bool(re.search(regex, text)) instead of the return m is not None
tfc
reviewed
Nov 9, 2019
10 tasks
marijanp
reviewed
Nov 11, 2019
Contributor
There was a problem hiding this comment.
@Mic92 I'm getting a Syntax Error in test-driver.py with your changes: SyntaxError: annotated name 'log' can't be global. (line 786)
Edit: It seems to be caused by the forward references. After commenting it out I don't get the syntax error anymore.
Member
Author
|
@marijanp fixed |
It's a good idea to expand this in future to test code as well, so we get type checking there as well.
Member
Author
|
@GrahamcOfBorg test borgbackup |
Member
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a good idea to expand this in future to test code as well,
so we get type checking there as well.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)Notify maintainers
cc @