Skip to content

gnome2.gnome_vfs: openssl-1.1 patch#72986

Merged
globin merged 1 commit intoNixOS:stagingfrom
oneingan:gnome_vfs_openssl11
Nov 12, 2019
Merged

gnome2.gnome_vfs: openssl-1.1 patch#72986
globin merged 1 commit intoNixOS:stagingfrom
oneingan:gnome_vfs_openssl11

Conversation

@oneingan
Copy link
Copy Markdown
Contributor

@oneingan oneingan commented Nov 7, 2019

Motivation for this change

Get rid of openssl-1.0 for java projects, I'm struggling to package java apps where openssl-1.1 is mandatory. I have override it successfully and think is interesting commit upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @globin @jtojnar

@oneingan
Copy link
Copy Markdown
Contributor Author

oneingan commented Nov 7, 2019

Sorry about not nix-review. The list of deps is too big for my laptop. Tested openjdk11 and working well.

@ofborg ofborg bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Nov 7, 2019
@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Nov 7, 2019

Does Java even still need those GNOME 2 dependencies? They have been deprecated for like ten years now.

@oneingan
Copy link
Copy Markdown
Contributor Author

oneingan commented Nov 7, 2019 •
edited
Loading

I guess not, but them are called by openjdk packages when enableGnome2 is true (default).

ping: @edwtjo

@oneingan
Copy link
Copy Markdown
Contributor Author

oneingan commented Nov 11, 2019

Related: #73246

jtojnar
jtojnar reviewed Nov 11, 2019
View reviewed changes
@jtojnar
Copy link
Copy Markdown
Member

jtojnar commented Nov 11, 2019

Could you squash the commits too?

@ofborg ofborg bot added 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 11, 2019
@oneingan
gnome2.gnome_vfs: openssl-1.1 patch
8ea52df 
Use fetchpatch and explain the issue
@ofborg ofborg bot removed 6.topic: haskell General-purpose, statically typed, purely functional programming language 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python Python is a high-level, general-purpose programming language. 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Nov 11, 2019
@globin globin merged commit bfe6cb0 into NixOS:staging Nov 12, 2019
@oneingan oneingan deleted the gnome_vfs_openssl11 branch November 12, 2019 22:31
@oneingan oneingan mentioned this pull request Nov 14, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jtojnar jtojnar jtojnar left review comments

@basvandijk basvandijk Awaiting requested review from basvandijk

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

No one assigned

Labels

10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches.

Projects

No open projects
Staging
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oneingan @jtojnar @globin @FRidh