Skip to content

nixos/tests: port some tests to python (loki, grafana, pgjwt, initrd-ssh, exporters)#72904

Merged
WilliButz merged 5 commits intoNixOS:masterfrom
WilliButz:nixosTests/port-to-python
Nov 7, 2019
Merged

nixos/tests: port some tests to python (loki, grafana, pgjwt, initrd-ssh, exporters)#72904
WilliButz merged 5 commits intoNixOS:masterfrom
WilliButz:nixosTests/port-to-python

Conversation

@WilliButz
Copy link
Copy Markdown
Member

@WilliButz WilliButz commented Nov 6, 2019 •
edited
Loading

Things done

Migrated most of the tests I maintain from the perl driver to python.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc #72828

@ofborg ofborg bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Nov 6, 2019
@WilliButz
Copy link
Copy Markdown
Member Author

WilliButz commented Nov 6, 2019

@GrahamcOfBorg test loki pgjwt initrd-network-ssh grafana

@WilliButz
Copy link
Copy Markdown
Member Author

WilliButz commented Nov 6, 2019

the test driver for grafana failed on x86_64:

Fatal Python error: could not acquire lock for <_io.BufferedWriter name='<stderr>'> at interpreter shutdown, possibly due to daemon threads

Thread 0x00007ffff5ac1700 (most recent call first):
  File "/nix/store/a1x3rkfv5af5wpsinwy6bnhwqgdiry4b-nixos-test-driver/bin/.nixos-test-driver-wrapped", line 85 in eprint
  File "/nix/store/a1x3rkfv5af5wpsinwy6bnhwqgdiry4b-nixos-test-driver/bin/.nixos-test-driver-wrapped", line 601 in process_serial_output
Thread 0x00007ffff62c2700 (most recent call first):
  File "/nix/store/a1x3rkfv5af5wpsinwy6bnhwqgdiry4b-nixos-test-driver/bin/.nixos-test-driver-wrapped", line 85 in eprint
  File "/nix/store/a1x3rkfv5af5wpsinwy6bnhwqgdiry4b-nixos-test-driver/bin/.nixos-test-driver-wrapped", line 601 in process_serial_output
Current thread 0x00007ffff7650b80 (most recent call first):
/nix/store/kirg08m7yzlp226q7ki61q9j5zjf1x9p-stdenv-linux/setup: line 1293:     6 Aborted                 LOGFILE=$out/log.xml tests='exec(os.environ["testScript"])' /nix/store/i8r4vhyp3c1mn3rgjgzghfmwdmd8y40f-nixos-test-driver-grafana/bin/nixos-test-driver
builder for '/nix/store/s0z4b92i2665czxl4mqq10g9ws4ddi8c-vm-test-run-grafana.drv' failed with exit code 134

@GrahamcOfBorg test grafana

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Nov 6, 2019
@tfc tfc mentioned this pull request Nov 6, 2019
Closed
tfc
tfc reviewed Nov 7, 2019
View reviewed changes
@WilliButz WilliButz force-pushed the nixosTests/port-to-python branch from 9685c96 to 426b467 Compare November 7, 2019 10:31
@WilliButz
Copy link
Copy Markdown
Member Author

WilliButz commented Nov 7, 2019

@tfc updated the subtest descriptions for the grafana test and rebased onto master :)

@WilliButz WilliButz merged commit d7b18bc into NixOS:master Nov 7, 2019
@WilliButz WilliButz deleted the nixosTests/port-to-python branch November 7, 2019 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tfc tfc tfc approved these changes

Assignees

No one assigned

Labels

6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@WilliButz @tfc